Skip to content

Fix bad link #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Fix bad link #10199

merged 1 commit into from
Aug 28, 2018

Conversation

tleneveu
Copy link
Contributor

The link http://localhost:4321/hello/?name=Fabien is not valid because it does not match the route /hello but the route /hello/ and therefore returns a 404 error.

It must be written this way:

http://localhost:4321/hello?name=Fabien

The link  http://localhost:4321/hello/?name=Fabien is not valid because it does not match the route /hello but the route /hello/ and therefore returns a 404 error.

It must be written this way:

http://localhost:4321/hello?name=Fabien
@weaverryan
Copy link
Member

Thank you Thibaut!

@weaverryan weaverryan merged commit 1761050 into symfony:2.8 Aug 28, 2018
weaverryan added a commit that referenced this pull request Aug 28, 2018
This PR was merged into the 2.8 branch.

Discussion
----------

Fix bad link

The link  http://localhost:4321/hello/?name=Fabien is not valid because it does not match the route /hello but the route /hello/ and therefore returns a 404 error.

It must be written this way:

http://localhost:4321/hello?name=Fabien

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

1761050 Fix bad link
@tleneveu tleneveu deleted the patch-1 branch August 29, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants